Clock: Introduce PSR-20 Clock Service as src/Data type
#4004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjansenDatabay
changed the title
PSR-20 Clock ServicePSR-20 Clock Service as src/Data type
|
Jour Fixe, 07 MAR 2022 : We highly appreciate this suggestion and accept this PR for trunk. |
mjansenDatabay
force-pushed
the
feature/8/clock-service
branch
from
cfdbe58 to
8904ae2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR I would like to introduce a
PSR-20compliantClock Service. While I refactoredServices/CronI once again stumbled upontime()anddate(), which caused issues due to wrong usage/wrong assumptions when dealing withnow(time()relies onJanuary 1 1970 00:00:00 GMTwhich is more or lessUTC,date()always relies ondate_default_timezone_set(), this MUST NOT be mixed when storingnowinformation or doing arithmetics when retrieving aY-m-d H:i:sback from the persistence layer).In addition the usage of these functions posseses the same issues like accessing the global scope or other infrastructure without relying on
Dependency Injection. Accessing thetimeordateis just another subtle way of “reaching out”, which makes it hard/impossible to test those methods.I would like to change this with this PR.
User LandPerspective: See https://github.com/ILIAS-eLearning/ILIAS/pull/4004/files#diff-19ff14f8652abd51b667e794b4258fa8cc58e7845c95af91fbc8ac15f0a41f8aR411